8854/feature/add share modal on my books page #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks, @noobCoderVP!
I've included some suggested changes to the /account/view.html template. Will be happy to merge this once those changes have been made.
jimchamp
added
the
Needs: Submitter Input
…al-on-my-books-page
…://github.com/noobCoderVP/openlibrary into 8854/feature/add-share-modal-on-my-books-page
for more information, see https://pre-commit.ci
|
I have made changes as you mentioned, please verify again! Still I have a lot to learn from you... |
mekarpeles
removed
the
Needs: Submitter Input
jimchamp
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8854
feature
Technical
Share modal component has been extended with a flag show_embed, default is True.
Testing
Visit My Books page and set the private settings: public, click on the Share button visible out there.
Screenshot
Stakeholders
@jimchamp