Fix: Seed.from_db()
now handles client.Thing
types
#8886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8882
Fix.
Thanks to @cdrini for very quickly figuring out the problem.
Technical
When there is a cache miss with a list containing a redirect,
Seed.from_db()
is called with aclient.Thing
type, but the logic didn't handle this.Testing
Create a list with a redirected item on it (e.g. by adding an item to the list and merging). Note: you cannot have the non-redirected version of the item before it on the same list or the error won't occur.
Try viewing the profile page of the account with the relevant list before and after applying the PR.
Screenshot
Before:
After:
Stakeholders
@RayBB
@cdrini