Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate revert button #8909

Merged

Conversation

Realmbird
Copy link
Contributor

Revert button styling on Edition pages shows link which should be hidden
Closes #2282
Fix

Technical

Is a quick fix to the duplicate revert buttons bug where there was two revert buttons instead of one.

Testing

  1. docker compose up
  2. http://localhost:8080/
  3. Go find a book
  4. Make Edit on book
  5. Click History
    6. Click previous version
    7. Look at side to see revert button

Screenshot

Before
After Fix

Stakeholders

@jdlrobson

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @Realmbird. We'll take the incremental approach and merge this.

@scottbarnes scottbarnes merged commit 2733ff1 into internetarchive:master Mar 16, 2024
3 checks passed
rebecca-shoptaw pushed a commit to rebecca-shoptaw/openlibrary that referenced this pull request Mar 19, 2024
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 19, 2024
rebecca-shoptaw pushed a commit to rebecca-shoptaw/openlibrary that referenced this pull request Mar 19, 2024
merwhite11 pushed a commit to merwhite11/openlibrary that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert button styling on Edition pages shows link which should be hidden
2 participants