Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8917
Avoids error that occurs when a private reading log page is visited.
Also, sets default fall-back value of
MyBooksTemplate.counts
to an emptydict
. This doesn't fix anything, but should give developers an indication, with a cursory glance, that this property is meant to be adict
.Technical
Today, whenever a private reading log page is visited, the default
mb.counts
value is an empty list. The reading log view handler attempts to set the values ofKEYS_TITLES
by accessingmb.counts
with a key, which causes an error whenmb.counts
is a list. The PR setsKEYS_VALUES
inside of the conditional that checks if the page is viewable, avoiding the error altogether.Testing
Screenshot
Stakeholders