Allow Docker to install web.py from git rather than latest release
#8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
the
Priority: 1
|
Labelling as high priority since this is blocking folks trying to work on internationalization. |
cdrini
approved these changes
Mar 28, 2024
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix. Fixes bug that was preventing successful runs of the
i18nscript toextractmessages in Docker by ensuring Docker installs thegit-installed version ofweb.pyif that is what is inrequirements.txt.Technical
Currently Docker runs of the script are causing
TokenErrors as a result of a mismatch between Python 3.12 and theweb.pyversion, which was solved in a recentweb.pygit commit, but not in the latest release.Testing
docker compose run --rm -uroot home ./scripts/i18n-messages extractA new
messages.potfile should be generated!Stakeholders
@cdrini