Switch to urllib for parsing query string in changequery #8997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8994
Fixes an issue where when multiple filters from the same category are added and then a filter from a different category is added using the side menu, only one of the multiple filters from the same category remain.
Technical
This bug occurred because we used
web.input
to generate our query dict, but doing so keeps only the last parameter if there are multiple that share the same key value. This pull request instead gets the query string fromweb.ctx.env
and uses urllib to parse it. This keeps all parameters in the query intact.Testing
Screenshot
If I have the following subject filters selected:
Adding a filter from a different category will not cause any of the previous filters to disappear:
Stakeholders