Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8996/bugfix/fix authors search result identation in small screens #9072

Conversation

Noronha01
Copy link
Contributor

Closes #8996

[fix]

Technical

  • Fixes weird indentation of authors search results when the screen width is smaller than the tablet breakpoint
  • Added css to handle this screen size for search result items.

Testing

Search for an author and reduce the screen width or change screen to tablet or smartphone.

Screenshot

Fixed author names and descriptions:
FixedIndentationScrnSht

Stakeholders

@scottbarnes

@scottbarnes
Copy link
Collaborator

Thanks for this, @Noronha01.

This issue is a bit of a weird one, in terms of how the issue only appears on the authors search result, or that is only where I saw it. Did you see it elsewhere also?

The PR does get the job done, but I am a bit unsure about collateral effects. As an alternative, what about changing this <div> to <div class="details">:

If that works, we get a targeted fix and don't have to add or modify any styles.

CC @cdrini, who came up with the idea of possibly using details here.

@Noronha01
Copy link
Contributor Author

Hi @scottbarnes
I haven't seen this bug anywhere else, only on the author search.
Changing the div to class details gets the job done! Thank you, I will update the PR.

@scottbarnes scottbarnes merged commit d5867d8 into internetarchive:master Apr 23, 2024
3 checks passed
merwhite11 pushed a commit to merwhite11/openlibrary that referenced this pull request May 2, 2024
…ternetarchive#9072)

* Fix CSS for author search result indentation on screens narrower than the tablet breakpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

author search has weird indentation for some authors
2 participants