Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gunicorn to 22.0.0 #9105

Merged

Conversation

scottbarnes
Copy link
Collaborator

@scottbarnes scottbarnes commented Apr 17, 2024

Closes: #9145

Fixes a high severity bug that didn't apply to our current setup, but had the potential be quite severe. This update may also increase performance.

Release notes:
https://docs.gunicorn.org/en/stable/news.html#id1

Stakeholders

@cdrini

Fixes a high severity bug that didn't apply to our current setup, but
had the potential be quite severe. This update may also increase
performance.

Release notes:
https://docs.gunicorn.org/en/stable/news.html#id1
@scottbarnes scottbarnes added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 17, 2024
@cdrini cdrini removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 23, 2024
@mekarpeles
Copy link
Member

@scottbarnes can we add an issue to this one and put it on our milestone for 2024-05?

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 24, 2024
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; changelog looks innocuous enough, and I tested moving around the site, uploading (at least the web-server side of uploading) and editing, and everything seemed to work! Excited to see if this has any perf impact!

@cdrini cdrini merged commit 940f31c into internetarchive:master Apr 24, 2024
3 checks passed
@cdrini
Copy link
Collaborator

cdrini commented Apr 24, 2024

Hmm it does list "Support python 3.12" in the release log... I wonder if that might be why it's faster?

@scottbarnes scottbarnes deleted the feature/update-gunicorn-to-22.0.0 branch April 25, 2024 03:51
@mekarpeles mekarpeles added the Needs: Special Deploy This PR will need a non-standard deploy to production label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gunicorn to 22.0.0
3 participants