-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved ajax-loader.gif to achieve better caching #9167
Conversation
Hi @RayBB, I'm not sure why there's 3 commits to this PR, since I created a new branch just for the caching issue. |
Got why I didn't see the update on references, didn't do |
@Spedi you could just undo the changes related to |
@RayBB Done that, it was an easy fix indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally and is working great!
Just need staff to merge then I'll update my other PR :)
The changes make sense, though I'm confused why we replaced the transparent version of the gif with one having a white background -- that may have some visual consequences. Cc: @RayBB |
@mekarpeles idk why github show sit as not transparent but this is what it looks like in prod already. The "transparent version" isn't used anywhere at all that's why we're removing it. |
Closes #9104
Moved
ajax-loader.gif
from thecss
folder to theimages
one, to achieve better caching, and updated all deprecated references to the file.Stakeholders
@RayBB