Remove unused util $.fn.focusNextInputField

[RayBB]

Closes #9179

Technical

Testing

Did a fulltext search of the code and these aren't used anywhere I can see but a second check would be good.
Removes one unused piece of code and adds a comment about why we want to keep the rest.

Screenshot

Stakeholders

[jimchamp]

Thanks @RayBB! The changes to the excerpts template are causing errors on the book edit page. Switching from string interpolation to string concatenation should fix things.

[jimchamp]

This is causing an error on the edit page. I think that the template parser is having issues with the $ character. Escaping the character (\$) led to some new errors in my browser's console output.

It's probably best to switch back to old-fashioned string concatenation for this case.

[RayBB]

@jimchamp good catch... it is fixed as you suggested!

[cdrini]

Howdy folks, I've been thinking about this one and I think it might be best for us to close this. Even if we remove the places where our jsdef code uses e.g. cond, it's expected that jsdef codeblocks should have access to these python globals. Removing the JS implementations here will make our code brittle, especially since we don't really have strong tests to verify that our python/jsdef templates are valid.

[cdrini]

To clarify, here is what I mean by jsdef using these files:

openlibrary/openlibrary/templates/subjects.html

Lines 84 to 91 in 1860c25

	$jsdef renderSubjects(subjects):
	$if len(subjects) > 0:
	<span class="subject">
	$for s in subjects:
	<a href="$s.key">$s.name</a>$cond(loop.last, '', ',')
	</span>
	$else:
	<span class="title"><em>$_("None found.")</em></span>

The cond call here uses the window.cond definition when this template is converted to/called from the JS.

[RayBB]

@cdrini thanks for replying.

Should we also keep focusNextInputField ?

Do we need to keep the window.cond = cond; for jsdef to work?
Or would it be feasible to move these to a window.jsdef.cond so they're not taking up so much at the top of index.js?

[cdrini]

focusNextInputField looks entirely unused; that looks like we can drop 👍 We do need the window.cond exposure in order for jsdef to work atm; if we wanted to change that, we would need to modify the way that the jsdef converts the templates to JS to check a certain global eg a JSDEF global. That would be nice in some future! But a little complicated to achieve. We'd need to change the parser to basically alter all globals to pull them from somewhere else. Here: https://github.com/internetarchive/openlibrary/blob/b46ff5135473c003f191d804bdd3b07cfa2c37cb/openlibrary/plugins/upstream/jsdef.py

[RayBB]

@cdrini sounds good to me. I've pushed code with a comment about this and removing focusNextInputField

[cdrini]

Lgtm! Tested on testing (the only place I can think where this might apply is the "add one?" link for description, which focusses on the description box; still works!) + can't find any references to that method.