Fix: update and escape a handful of templates #9258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
extract/i18n-messages extract
by default now, but we need to get themaster
branch in a state where the command can run cleanly, or the files in this commit will get flagged with any commit that makes ani18n
change.This seems to be confusing people.
Edit: I double checked by adding another commit with an
i18n
text change and no accompanying update tomessages.pot
within the PR. on push,pre-commit
ran, failed becausemessage.pot
changed by way of thepre-commit
hook, added the updatedmessages.pot
to the PR, ran again, and succeeded. This is evidence, though not entirely conclusive, that it may fix things for, e.g., #9246.Testing
master
branch.Run
pre-commit
to generate the POT files, and see that it both fails and generates a newi18n/messages.pot
:Stakeholders