Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add spaces when matching author honorifics #9322

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix: add spaces when matching author honorifics #9322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openlibrary/catalog/add_book/load_book.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,11 @@ def remove_author_honorifics(name: str) -> str:
(
honorific
for honorific in HONORIFICS
if name.casefold().startswith(honorific)
if name.casefold().startswith(f"{honorific} ") # Note the trailing space.
),
None,
):
return name[len(honorific) :].lstrip() or name
return name[len(f"{honorific} ") :].lstrip() or name

return name

Expand Down
1 change: 1 addition & 0 deletions openlibrary/catalog/add_book/tests/test_load_book.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def add_three_existing_authors(self, mock_site):
@pytest.mark.parametrize(
["name", "expected"],
[
("Drake von Drake", "Drake von Drake"),
("Dr. Seuss", "Dr. Seuss"),
("dr. Seuss", "dr. Seuss"),
("Dr Seuss", "Dr Seuss"),
Expand Down
Loading