Remove extra checks from extract_messages
#9442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9396.
Fix. Removes checks from the
extract_messages
function that are unnecessary now that the timestamp is standardized so as to catch a few more cases.Technical
Also removed the
--force-write
option, as the function will now always write a new template.Testing
pre-commit
should fail and auto-update themessages.pot
filemessages.pot
changes and commit again --pre-commit
should passpre-commit
should simply passpre-commit
should run the same process as steps 1 & 2 even though no text has been added, changed or deletedScreenshot
Stakeholders
@cdrini