Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra checks from extract_messages #9442

Conversation

rebecca-shoptaw
Copy link
Collaborator

Closes #9396.

Fix. Removes checks from the extract_messages function that are unnecessary now that the timestamp is standardized so as to catch a few more cases.

Technical

Also removed the --force-write option, as the function will now always write a new template.

Testing

  1. Make a change to onscreen text in an HTML/Python file and commit -- pre-commit should fail and auto-update the messages.pot file
  2. Stage the messages.pot changes and commit again -- pre-commit should pass
  3. Make a change to an HTML/Python file that does not change the position or contents of on-screen text -- pre-commit should simply pass
  4. Make a change that involves moving on-screen text between files or changing the name of a file with on-screen text -- pre-commit should run the same process as steps 1 & 2 even though no text has been added, changed or deleted

Screenshot

Stakeholders

@cdrini

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm, thank you @rebecca-shoptaw ! Not testing since your testing looks super thorough!

@cdrini cdrini merged commit 7f3e4a0 into internetarchive:master Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving strings should generate the messages.pot
2 participants