Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Slack digest for new comments #9455

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

jimchamp
Copy link
Collaborator

Correctly compares GitHub username to lead label. Previous code was throwing a StopIteration error due to a match never being made in the next call.

Technical

Testing

Screenshot

Stakeholders

@mekarpeles mekarpeles self-assigned this Jun 24, 2024
Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Jun 24, 2024
@jimchamp
Copy link
Collaborator Author

Squash on merge.

@mekarpeles mekarpeles merged commit 3a59fc5 into internetarchive:master Jun 26, 2024
4 checks passed
@jimchamp jimchamp deleted the fix-new-comment-script branch August 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants