Fix Search Box Only Visible On Want To Read #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to take a look at this one @rebecca-shoptaw ? It's deploying to testing now! |
cdrini
changed the title
cdrini
added
the
On testing.openlibrary.org
rebecca-shoptaw
approved these changes
Jul 10, 2024
rebecca-shoptaw
added
the
Needs: Staff / Internal
rebecca-shoptaw
removed
the
Needs: Staff / Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9547
This PR achieves a quick fix to return the search bars to users' already-read and currently-reading pages. Somehow, the names of two of the keys used to check rendering got changed, so the search bar was no longer loading.
Technical
There was very little technical about this issue, it just involved fixing some changes made to a template's variables.
Testing
Go to your already_read or currently_reading pages on your account, and see the search bar.
Screenshot
Stakeholders
@cdrini