Temporarily downscale 8XXXXXX-L.jpg covers #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backing IA item is struggling with traffic, but will be re-enabled once it is switched from .tar to .zip in the next week or so
cdrini
added
Priority: 1
|
Marking as high priority @mekarpeles , we need this merged in before the next deploy (which will likely be Tu-Th of this week) |
The code previously returned notfound in get_details if the value wasn't an int. Instead, push that logic up to avoid erroring unexpectedly, and avoid having to convert to an int multiple times.
cdrini
commented
Jul 16, 2024
|
Auto-merging this since it needs to go out in today's deploy. Please feel free to review after the fact, @mekarpeles ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #9560
The backing IA item is struggling with traffic, but will be re-enabled once it is switched from .tar to .zip in the next week or so
Technical
Testing
Previously erroring covers (eg https://covers.openlibrary.org/b/id/8791306-L.jpg) are no longer erroring and serving the smaller image
Screenshot
Stakeholders
@mekarpeles @hbromley