Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing square brackets causing solr-updater error #9669

Conversation

benbdeitch
Copy link
Collaborator

@benbdeitch benbdeitch commented Jul 31, 2024

Addendum to #9545 .

This one-line pull request fixes an attempt to access certain keys by dot notation, rather than via brackets. It's a simple fix, so no issue was created.

Stakeholders

@cdrini

@benbdeitch benbdeitch requested a review from cdrini July 31, 2024 20:34
@cdrini cdrini changed the title Added square brackets Added missing square brackets Jul 31, 2024
@cdrini cdrini self-assigned this Jul 31, 2024
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested on gitpod that the authors are in the search:

/solr/#/openlibrary/query?q=type:author&q.op=OR&indent=true&wt=json&useParams=

@cdrini cdrini changed the title Added missing square brackets Fix missing square brackets causing solr-updater error Jul 31, 2024
@cdrini cdrini merged commit 3420218 into internetarchive:master Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants