Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate mypy stub dependencies forpre-commit #9774

Conversation

scottbarnes
Copy link
Collaborator

Closes #9750

This commit adds the stubs necessary for pre-commit run --all-files to run successfully.

types-all has been deprecated and removed from PyPI: https://github.com/asottile-archive/types-all

See
https://mypy.readthedocs.io/en/stable/running_mypy.html#library-stubs-not-installed for more.

Technical

Testing

Tested with:

❯ pre-commit clean
❯ pre-commit run --all-files

Screenshot

Stakeholders

@cdrini

Closes internetarchive#9750

This commit adds the stubs necessary for `pre-commit run --all-files` to
run successfully.

`types-all` has been deprecated and removed from PyPI:
https://github.com/asottile-archive/types-all

See
https://mypy.readthedocs.io/en/stable/running_mypy.html#library-stubs-not-installed
for more.

Tested with:
```
❯ pre-commit clean
❯ pre-commit run --all-files
```
@github-actions github-actions bot added the Priority: 2 Important, as time permits. [managed] label Aug 19, 2024
@scottbarnes scottbarnes changed the title Enumerate mypy stubs Enumerate mypy stub dependencies forpre-commit Aug 19, 2024
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitpod now works, ty!

@cdrini cdrini merged commit 71425e6 into internetarchive:master Aug 20, 2024
4 checks passed
@scottbarnes scottbarnes deleted the 9750/fix/remove-mypy-types-all-dependency branch August 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit failing because of additional dependency of mypy - types-all dependency
2 participants