Prefill "Add Tag" form #9775
Merged
Prefill "Add Tag" form #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unused parameters `name` and `tag` from the Tag creation template. Also removes the `recaptcha` parameter and template call, as Tag creation is restricted to librarians.
The `/tag/add` handler now requires a Tag `name` and `type`. These values, and the subject type, are now included in the URL of the subject page "Edit" link when Tags can be created.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9685
Passes Tag
name,type, and optionalsub_type(for subject type) from the subject page to the Tag creation template.The
nameandtypeparameters are now required by the/tag/addGET handler.Tag creation form is now prefilled with the
nameandtype. ReCaptcha has been removed from the "Add Tag" page, as this view is restricted to librarians.Technical
Testing
While logged in as a
super-librarian(this is important and checked on subject page --- will be fixed later):Screenshot
Stakeholders