Add readable URL slugs to Tag pages #9776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9779
Adds a readable slug to Tag URLs. The slug is created from the Tag's
name
property.Ensures that both types of edit requests are processed by the same handler (e.g.
/tags/OL1T/magic/edit
and/tags/OL1T/magic?m=edit
).Technical
Testing
While logged in as a
super-librarian
, test the following:?m=edit
URLs. Ensure that you are redirected to a/tags/{tag_olid}/{slug}/edit
page when this is clicked./tags/{tag_olid}/{slug}/edit
edit page. Ensure that the edit page is reachable when "Edit" is pressed. Important: Legacy subject to subject Tag linkage is buggy today. To avoid issues while testing, pick asubject
-type subject that has no special characters in the subject name.Screenshot
Stakeholders