Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readable URL slugs to Tag pages #9776

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Aug 20, 2024

Closes #9779

Adds a readable slug to Tag URLs. The slug is created from the Tag's name property.

Ensures that both types of edit requests are processed by the same handler (e.g. /tags/OL1T/magic/edit and /tags/OL1T/magic?m=edit).

Technical

Testing

While logged in as a super-librarian, test the following:

  1. Paste a Tag URL in your browser's address bar. If the URL has a readable slug, remove it. Press enter to navigate to the view. Expect the URL to be rewritten to include a slug.
  2. The "Edit" buttons on Tag views use the ?m=edit URLs. Ensure that you are redirected to a /tags/{tag_olid}/{slug}/edit page when this is clicked.
  3. If a Tag is linked to a subject, that subject page's "Edit" button will take the patron to a /tags/{tag_olid}/{slug}/edit edit page. Ensure that the edit page is reachable when "Edit" is pressed. Important: Legacy subject to subject Tag linkage is buggy today. To avoid issues while testing, pick a subject-type subject that has no special characters in the subject name.

Screenshot

Stakeholders

@jimchamp jimchamp marked this pull request as draft August 20, 2024 20:18
@jimchamp jimchamp marked this pull request as ready for review August 20, 2024 21:28
@jimchamp jimchamp marked this pull request as draft August 20, 2024 22:57
@jimchamp jimchamp marked this pull request as ready for review August 20, 2024 23:46
@mekarpeles mekarpeles merged commit 0785a1a into internetarchive:master Aug 26, 2024
3 of 4 checks passed
@jimchamp jimchamp deleted the 9685/feature/readable-urls-for-tags branch August 27, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add readable slugs to Open Library's Tag URLs
2 participants