Add typehints in openlibrary.accounts module

[yivgen]

Related to #8028

Adds typehints to openlibrary.accounts and openlibrary.plugins.upstream.mybooks modules

Technical

Testing

Screenshot

Stakeholders

@scottbarnes

[yivgen]

Hi! I've been very busy for the past few days but I can continue working on this now

[yivgen]

Also monkeytype suggests adding typehints in ReadingLog innit like so:

def __init__(self, user: User | None = ...) -> None:

but then self.user could hypothetically be None but that wouldn't work with a lot of the methods like lists, booknotes_counts, reading_log_counts, count_shelf and get_works
And I'm not sure what to do about that

[scottbarnes]

This looks great, @yivgen. Just one minor piece of substantive feedback. Great job handling the if TYPE_CHECKING stuff, and the 'mess' between list and List.

I think the way you handled the case you mentioned makes sense. MonkeyType is far from perfect, sadly. :)

[scottbarnes]

I see you had to make this change to get mypy to pass, and in terms of fixing the error, I would say this is an acceptable thing to do for now. It does however expose an oversight on the part of the knucklehead who wrote this function.

What probably needs to happen here is a dependency injection-like thing, where the username is passed into batch_import. This current implementation sets up a case where (1) it's harder to unit test batch_import than it should be, and (2) people using the function may end up with a submitter of None without expecting it.

Right now, however, batch_import is only called in one place, and there it is gated by a requirement that the account be in the /usergroup/admin group:

openlibrary/openlibrary/plugins/openlibrary/code.py

Lines 499 to 501 in 341c890

	user_key = delegate.context.user and delegate.context.user.key
	if user_key not in _get_members_of_group("/usergroup/admin"):
	raise Forbidden('Permission Denied.')

So let's just leave this change for now, as user.get_username() won't return None the way the function is currently called`, and it will be a future task to fix this up and write some tests.

[scottbarnes]

Good catch here:

openlibrary=# \d bookshelves_books
                         Table "public.bookshelves_books"
    Column    |            Type             |              Modifiers
--------------+-----------------------------+--------------------------------------
 username     | text                        | not null
 work_id      | integer                     | not null
 bookshelf_id | integer                     | not null
 edition_id   | integer                     |
 private      | boolean                     |
 updated      | timestamp without time zone | default timezone('utc'::text, now())
 created      | timestamp without time zone | default timezone('utc'::text, now())

[scottbarnes]

Thanks for this, @yivgen!