Apply search bar template to subjects page #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schu96
force-pushed
the
9236/refactor/apply-search-bar-template
branch
from
cb847ec to
0f9ae5a
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9830 +/- ##
==========================================
+ Coverage 16.06% 16.45% +0.39%
==========================================
Files 90 91 +1
Lines 4769 4899 +130
Branches 832 853 +21
==========================================
+ Hits 766 806 +40
- Misses 3480 3559 +79
- Partials 523 534 +11 ☔ View full report in Codecov by Sentry. |
mekarpeles
added
the
On testing.openlibrary.org
|
Note: On testing, we're seeing unexpected behavior re: i18n placeholder for the search form, but this may be unrelated to this PR and instead related to testing cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9236
Refactor
Technical
Replaced previous search bar with the template defined in
searchbox.htmlfor the Subject page.Just noticed that the subject not found page also has a search bar that can be replaced with the template, will push an updated PR to also apply this change.
Testing
Go to a subject page that has books and a subject page that does not have books.
Screenshot
Current prod search bar:
Updated template search bar:
Stakeholders