Remove ineffective strings in "Independently Published" exclusion list #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverts some recently added title match strings -- dumpbins are not independently published. These strings are very unlikely to match, but there is another method to reject these still in place, the `OTH` product class test. This removes the strings to avoid any confusion about whether they are effective. via @cdrini 's comment: https://github.com/internetarchive/openlibrary/pull/9850/files/eb3f33645b247c8fe70c3a71215b05e272f42c61#r1752032348
hornc
added
the
Module: Import
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts some recently added title match strings -- dumpbins are not independently published. These strings are very unlikely to match, but there is another method to reject these still in place, the
OTHproduct class test. This removes the strings to avoid any confusion about whether they are effective.via @cdrini 's comment:
https://github.com/internetarchive/openlibrary/pull/9850/files/eb3f33645b247c8fe70c3a71215b05e272f42c61#r1752032348
Closes #
Technical
Testing
Screenshot
Stakeholders