Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BulkTagger menu option bug #9892

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

jimchamp
Copy link
Collaborator

Closes #9891

Corrects misspelled tag property, which was preventing tags from being removed from the tagsToRemove array.

Technical

Testing

While logged-in with an account that can use the bulk tagger:

  1. Navigate to a search result page.
  2. Select at least one work.
  3. Click the "Tag Works" button to open the bulk tagger.
  4. Click on an existing menu option to stage the tag for removal.
  5. Click the same menu option to stage the tag for addition.
  6. Close the bulk tagger.
  7. Open the bulk tagger again. Verify that there are no duplicate menu options.

Screenshot

Stakeholders

@jimchamp jimchamp force-pushed the bug/prevent-duplicate-menu-options branch from 628c0bd to ea23a87 Compare September 18, 2024 20:00
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, not testing, seems pretty simple.

@cdrini
Copy link
Collaborator

cdrini commented Sep 23, 2024

Ignoring the failing test it's fixed on master (bundlesize bump)

@cdrini cdrini merged commit 508d9c4 into master Sep 23, 2024
3 of 5 checks passed
@cdrini cdrini deleted the bug/prevent-duplicate-menu-options branch September 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate menu options displayed in BulkTagger
2 participants