Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/move TOC parsing/rendering code #9910

Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Sep 26, 2024

Part of #8756 . Refactor with no user-discernable effects to move the parsing into table_of_contents.py and create a new helper class to manage tables of contents. Stepping stone for the next piece which will support entry data like authors, etc.

Depends on #9902 .

Technical

Testing

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.05%. Comparing base (ce16a79) to head (8dd66a9).
Report is 449 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9910      +/-   ##
==========================================
+ Coverage   16.06%   17.05%   +0.99%     
==========================================
  Files          90       89       -1     
  Lines        4769     4725      -44     
  Branches      832      829       -3     
==========================================
+ Hits          766      806      +40     
+ Misses       3480     3409      -71     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the feature/toc-authors-editing branch from 8dd66a9 to 172b011 Compare September 26, 2024 20:04
@cdrini cdrini changed the title Draft: Ability to edit TOC authors/subtitles/descriptions on edit page Refactor/move TOC parsing/rendering code Sep 26, 2024
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Sep 26, 2024
@cdrini cdrini force-pushed the feature/toc-authors-editing branch from 641b719 to 115cfd1 Compare September 27, 2024 14:53
@cdrini cdrini marked this pull request as ready for review September 27, 2024 15:33
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Sep 27, 2024
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scottbarnes scottbarnes merged commit 77c16d5 into internetarchive:master Sep 27, 2024
3 checks passed
@cdrini cdrini deleted the feature/toc-authors-editing branch September 27, 2024 20:14
DanielleInkster pushed a commit to DanielleInkster/openlibrary that referenced this pull request Oct 1, 2024
* Refactor TOC parsing/printing to be in table_of_contents.py
* Handle table of contents can be None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants