Temporarily disable erroring network requests #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
On testing.openlibrary.org
Patch Deployed
jimchamp
approved these changes
Oct 30, 2024
cdrini
added
the
Temporary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables prices rendering, wikidata fetching (which can cause timeouts), and cover add by url.
Technical
These requests were hanging around, timing out after like 30s, causing our haproxy's queue to fill up and resulting in a lot of 500s. Disabling them for now. Patch deployed this ~a week ago; not only this chunk, not the covers UI change has been patch deployed.
Also disabling the covers upload by URL UI, since it won't work for the time being.
Testing
Screenshot
Stakeholders
@mekarpeles