Fix minor py37+ issues #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 13, 2020 09:48
We see the following warning using py37.
```
surt/handyurl.py:37: DeprecationWarning: invalid escape sequence \+
_RE_HAS_PROTOCOL = re.compile(b"^([a-zA-Z][a-zA-Z0-9\+\-\.]*):")
```
We resolve it by adding `r` prefix to that string. This is already used
in some other regex strings in the same file.
This code was triggering an error only on `pypy3` unit tests. We add a check to convert to str if `host` is `bytes`.
Limit pkg versions to be compatible with older python versions. Add `py38` to the target envs.
After that version, `pytest-cov` requires a newer `pytest` and we have a conflict with `pytest<5`.
vbanos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for
py37andpy38, removepy26andpy33.Fix bytes/str issue that caused
pypy3tests to fail.Update
.travis.cito limit versions ofpytest,pytest-covto allow tests to run in all python versions.Resolve py37+ warnings like the following by adding
rprefix to that regex.