finished whois disclosing part #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlerikounapuu
approved these changes
Feb 25, 2021
|
there are still issues here. Example: the domain belongs to an org so the user should not be able to undisclose any of the data, but in this instance user is able to hide their data as admin contact. Furthermore, ui shows that tech contact data is disclosed as is supposed to be, but in the rwhois I see so even though tech contact is disclosed its still hidden in whois |
|
These are the issues still there:
the domains are registered to an organisation |
vohmar
deleted the
29-whoise-disclose-data-in-the-portal-is-incorrect-for-admin-and-tech-contacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29