Skip to content

Commit

Permalink
Ensure unique EPP session id
Browse files Browse the repository at this point in the history
  • Loading branch information
Artur Beljajev committed Feb 13, 2018
1 parent 40c1238 commit 4ec4e50
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/epp_session.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ class EppSession < ActiveRecord::Base
belongs_to :user, required: true
belongs_to :registrar

validates :session_id, presence: true
validates :session_id, uniqueness: true, presence: true
end
14 changes: 14 additions & 0 deletions test/models/epp_session_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,18 @@ def test_invalid_without_user
@epp_session.validate
assert @epp_session.invalid?
end

def test_invalid_if_persisted_record_with_the_same_session_id_exists
epp_session = EppSession.new(session_id: @epp_session.session_id, user: @epp_session.user)
epp_session.validate
assert epp_session.invalid?
end

def test_database_session_id_unique_constraint
epp_session = EppSession.new(session_id: @epp_session.session_id, user: @epp_session.user)

assert_raises ActiveRecord::RecordNotUnique do
epp_session.save(validate: false)
end
end
end

0 comments on commit 4ec4e50

Please sign in to comment.