-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve deprecation warnings #1521
Comments
The main bunch of changed deprecated warnings comes form the papertrail gem - so we need either pump it's version to latest (requires some refactoring due to papertrail API changes) or get rid of it completely. |
Getting rid of papertrail is not possible at the moment because we have nothing to replace it with. So refactoring it is unless it's multi-day undertaking |
The refactoring will take from a couple of hours to a couple of days. |
There are very many deprecation warnings returned during deployment clogging the logs. Let get rid of these.
Current master build: https://travis-ci.org/internetee/registry/builds/647285407
changed_attributes
inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method aftersave
returned (e.g. the opposite of what it returns now). To maintain the current behavior, usesaved_changes.transform_values(&:first)
instead. (called from update_related_whois_records at /home/travis/build/internetee/registry/app/models/contact.rb:487)changes
inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method aftersave
returned (e.g. the opposite of what it returns now). To maintain the current behavior, usesaved_changes
instead. (called from update_related_whois_records at /home/travis/build/internetee/registry/app/models/contact.rb:487)changed
inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method aftersave
returned (e.g. the opposite of what it returns now). To maintain the current behavior, usesaved_changes.keys
instead. (called from update_related_whois_records at /home/travis/build/internetee/registry/app/models/contact.rb:487)attribute_change
inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method aftersave
returned (e.g. the opposite of what it returns now). To maintain the current behavior, usesaved_change_to_attribute
instead. (called from update_related_whois_records at /home/travis/build/internetee/registry/app/models/contact.rb:487)attribute_changed?
inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method aftersave
returned (e.g. the opposite of what it returns now). To maintain the current behavior, usesaved_change_to_attribute?
instead. (called from update_related_whois_records at /home/travis/build/internetee/registry/app/models/contact.rb:487)The text was updated successfully, but these errors were encountered: