Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrars' phone, email and web address to automatic emails #180

Closed
vohmar opened this issue Sep 20, 2016 · 14 comments
Closed

Registrars' phone, email and web address to automatic emails #180

vohmar opened this issue Sep 20, 2016 · 14 comments

Comments

@vohmar
Copy link
Contributor

vohmar commented Sep 20, 2016

There is a reference to the registrar holding the registration to a domain in automatic email notices sent by the registry (https://github.com/internetee/registry/tree/master/app/views/mailers), but no registrar contact data. The e-mail messages should have registrar's phone number, email address and web address as well (if exists in registry db).

@vohmar vohmar added this to the Sprint 10.09 milestone Oct 4, 2016
@artur-intech
Copy link
Contributor

artur-intech commented Oct 9, 2016

Extended registrar's info has been added to the following mailers:

  • expiration
  • force_delete

@artur-intech
Copy link
Contributor

artur-intech commented Oct 9, 2016

I was unable to run the following mailers:
pending_update_rejected_notification_for_new_registrant
pending_update_expired_notification_for_new_registrant
pending_update_notification_for_new_registrant

So as soon as I get some clarification, what is the correct way to run them, I will add that info there as well (as a separate ticket, probably)

Extracted to #204

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Oct 9, 2016
@vohmar
Copy link
Contributor Author

vohmar commented Oct 11, 2016

registrar data missing (email are sent out):

  • pending_deleted
  • pending_update_request_for_old_registrant
  • pending_update_notification_for_new_registrant
  • pending_update_rejected_notification_for_new_registrant
  • pending_update_expired_notification_for_new_registrant

OK

  • force_delete

Error

@artur-intech
Copy link
Contributor

@vohmar Is this the correct subject for force_delete mailer - "Kustutusmenetluse teade"?

@artur-intech
Copy link
Contributor

  • Removed invalid logo url from force_delete mailer

@vohmar
Copy link
Contributor Author

vohmar commented Oct 31, 2016

@artur-beljajev there is currently no notable issue with mailer subjects, lets focus on adding the missing content.

@artur-intech
Copy link
Contributor

in branch registry-186

@artur-intech
Copy link
Contributor

artur-intech commented Oct 31, 2016

Blocked by #233

artur-intech pushed a commit that referenced this issue Nov 3, 2016
artur-intech pushed a commit that referenced this issue Nov 7, 2016
artur-intech pushed a commit that referenced this issue Nov 10, 2016
artur-intech pushed a commit that referenced this issue Nov 10, 2016
artur-intech pushed a commit that referenced this issue Nov 11, 2016
artur-intech pushed a commit that referenced this issue Nov 13, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
artur-intech pushed a commit that referenced this issue Nov 14, 2016
@artur-intech
Copy link
Contributor

P.S. the reason why I was unable to run them before was that I have tested it against staging branch, which was outdated.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Nov 14, 2016
@vohmar
Copy link
Contributor Author

vohmar commented Nov 16, 2016

@artur-beljajev where is the branch that I can merge to test this? Email templates are currently missing from staging.

@vohmar vohmar assigned artur-intech and unassigned vohmar Nov 16, 2016
@artur-intech
Copy link
Contributor

artur-intech commented Nov 17, 2016

Please look for a branch above.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Nov 17, 2016
@artur-intech
Copy link
Contributor

Fixed

@vohmar
Copy link
Contributor Author

vohmar commented Nov 21, 2016

Solved in #186 with outstanding issues

@vohmar vohmar assigned artur-intech and vohmar and unassigned vohmar and artur-intech Nov 21, 2016
@vohmar
Copy link
Contributor Author

vohmar commented Dec 14, 2016

#186 is in production, closed

@vohmar vohmar closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants