Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check domain expiration logic #238

Closed
artur-intech opened this issue Nov 7, 2016 · 3 comments
Closed

Check domain expiration logic #238

artur-intech opened this issue Nov 7, 2016 · 3 comments

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Nov 7, 2016 •
edited
Loading

domain is set as expired when timpestamp now > valid to
domain is set on hold (removed from zone) when timestamp now > outzone at
domain is set as delete candidate and random delete time is calculated when timestamp now > delete at
domain is deleted if domain has delete candidate status set

extracted from #235
@artur-intech artur-intech self-assigned this Nov 7, 2016
artur-intech pushed a commit that referenced this issue Nov 7, 2016
Extract expirable concern from domain model
e653d8b 
#238
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Nov 8, 2016
artur-intech pushed a commit that referenced this issue Nov 8, 2016
Consider domains having current time at "expire_time" attribute expired
877e699 
Fixes #238
artur-intech pushed a commit that referenced this issue Nov 14, 2016
Use app timezone in domain#delete_candidateable?
41d3e62 
#238
@vohmar vohmar mentioned this issue Nov 16, 2016
Closed
@vohmar
Copy link
Contributor

vohmar commented Nov 16, 2016 •
edited
Loading

@teadur please have a quick code review https://github.com/internetee/registry/compare/master...registry-238?expand=1 - especially are the tests OK

@vohmar
Copy link
Contributor

vohmar commented Nov 16, 2016

@artur-beljajev https://github.com/internetee/registry/compare/master...registry-238?expand=1#diff-26556a08a299ddd06db8192756a22566R14 registered? is very bad usage of terminology as expired domains are also registered. It is preferable to avoid this kind of checks and test if a domain is expired (instead of "is it not expired"). But if this check is necessary rename registered? to not_expired - more descriptive and correct in domain terminology.

@vohmar vohmar assigned teadur and unassigned vohmar Nov 16, 2016
@vohmar vohmar closed this as completed in aa29c78 Nov 25, 2016
This was referenced Nov 25, 2016
Merged
Merged
artur-intech pushed a commit that referenced this issue Nov 29, 2016
Use app timezone in domain#delete_candidateable?
cda8883 
#238
@teadur teadur removed their assignment Dec 1, 2016
@vohmar
Copy link
Contributor

vohmar commented Dec 14, 2016

branch deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teadur @vohmar @artur-intech