Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directo: admin missing directo_handle #343

Closed
vohmar opened this issue Jan 18, 2017 · 9 comments
Closed

Directo: admin missing directo_handle #343

vohmar opened this issue Jan 18, 2017 · 9 comments
Assignees
Labels

Comments

@vohmar
Copy link
Contributor

vohmar commented Jan 18, 2017

In the admin interface there is no option to fill directo_handle information for regsitrars. It is also not returned in UI to see the effective value.

directo_handle is part of Directo integration - necessary to match registrars in registry system to companies in accounting system.

  • add a field to enter and edit directo handle value in create and edit registrar forms
  • return directo handle value in registrar profile view

in generic view we should try to redesign directo integration into separate integrator module as a non standard EIS specific feature.

@artur-intech
Copy link
Contributor

How current registrars in production got their values? Manually?

@vohmar
Copy link
Contributor Author

vohmar commented May 8, 2017

imported from FRED and new registrars by manual intervention

@vohmar vohmar added the bug label May 8, 2017
@artur-intech
Copy link
Contributor

directo_handle is part of Directo integration - necessary to match registrars in registry system to companies in accounting system.

so "directo_handle" is a kind of registrar's uid (unique id) in Directo?

@ratM1n
Copy link

ratM1n commented May 17, 2017

Yes, some do match with registrar 'code' in our system. I suggest to handle it so, that if 'directo_handle' is present, use 'directo_handle', if not, use 'code'

@artur-intech
Copy link
Contributor

Decided to always require that Directo handle (which is now more abstract accounting_customer_code)

@artur-intech
Copy link
Contributor

artur-intech commented Oct 25, 2017

@teadur or @ratM1n Please make sure production env has no empty or NULL values.

@artur-intech
Copy link
Contributor

artur-intech commented Oct 27, 2017

Added under "General" section.

artur-intech pushed a commit that referenced this issue Oct 27, 2017
artur-intech pushed a commit that referenced this issue Oct 27, 2017
@artur-intech
Copy link
Contributor

#376 has been merged with this ticket since in addition to having dead code, that rake task modifies standard rake tasks in a way that prevents rake test from running.

@artur-intech
Copy link
Contributor

Test Directo export.

This was referenced Nov 23, 2017
artur-intech pushed a commit that referenced this issue Dec 8, 2017
artur-intech pushed a commit that referenced this issue Dec 8, 2017
Prod-like environments do not have it, therefore no migration

#343
@vohmar vohmar closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants