Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow prices and zones to be permanently deleted #522

Closed
artur-intech opened this issue May 17, 2017 · 14 comments
Closed

Do not allow prices and zones to be permanently deleted #522

artur-intech opened this issue May 17, 2017 · 14 comments
Assignees
@vohmar

Comments

@artur-intech
Copy link
Contributor

artur-intech commented May 17, 2017 •
edited
Loading

  1. Zone cannot be deleted
  2. Price cannot be deleted
  3. Price can be expired (button "Expire now"). Sets "valid_to" to current time
  4. A user can filter expired/unexpired prices
  5. Only unexpired prices are displayed by default
@vohmar vohmar mentioned this issue May 17, 2017
Open
artur-intech pushed a commit that referenced this issue May 23, 2017
Do not allow to permanently remove a zone
3526782 
#522
artur-intech pushed a commit that referenced this issue May 23, 2017
Do not allow to permanently remove a price
7d94273 
#522
artur-intech pushed a commit that referenced this issue May 25, 2017
Fix price edit view
67b1e9a 
#522
artur-intech pushed a commit that referenced this issue May 25, 2017
Add price expiration
58ae53b 
#522
@artur-intech
Copy link
Contributor Author

#507

@vohmar
Copy link
Contributor

vohmar commented Jun 1, 2017

  • Unexpired filter returns zero rows in staging although plenty of active price records exist.
  • expired a price list record but could still register a domain for that period with the price of expired domain (looks like expire action makes the record expired starting from a new day)

@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 1, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 2, 2017 •
edited
Loading

№ 1: Fixed (NULL in valid_to wasn't considered as effective). Introduced "upcoming" in status filter.
№ 2: #538

artur-intech pushed a commit that referenced this issue Jun 3, 2017
Consider nil in price expire time as effective
f76e125 
#522
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Jun 3, 2017
artur-intech pushed a commit that referenced this issue Jun 4, 2017
Refactor price statuses
f3e790b 
#522
@vohmar
Copy link
Contributor

vohmar commented Jun 6, 2017

actions that user pricelist fail - ie domain:renew results with "not elligible for renewal" / "internal error" messages
few example on staging:

  • /admin/epp_logs/45888
  • /admin/epp_logs/45920

Seems to be a problem with atribute names:
FROM-EPP-RESCUE: unknown attribute 'log_pricelist_id' for AccountActivity.

@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 6, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 8, 2017 •
edited
Loading

This is due to staging env problems (see Skype chat for details)

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Jun 8, 2017
@artur-intech
Copy link
Contributor Author

I merged #475 so now it should be ok

@vohmar
Copy link
Contributor

vohmar commented Jun 9, 2017

the fileters of the prices are no good

  • effective filter does not include prices with startdate or enddate as today (these are in expired list instead)
  • interface does not remember the filteres selected after returning from price edit view forcing user to reapply any filter they were using before.

@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 9, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 12, 2017 •
edited
Loading

  1. Not sure I understood the problem. Perhaps it's because Time is not supported as validity in price form #538? I checked "expired" list for anomalies, and didn't notice any. Also checked spec:

    registry/spec/models/billing/price_spec.rb

    Line 65 in f3e790b

    describe '::effective' do

    and it also passed. It would be good if you check it.
  2. If you go back using browser "back" button right after you clicked something on index page, then all filter params are preserved. If you edited, and clicked "save", sure it doesn't save filter params, since it requires storing it somewhere (in session, for example) and there wasn't such requirement. Create additional ticket if you really need this, but keep in mind it introduces complexity, so this feature should be justified.

@artur-intech artur-intech removed their assignment Jun 12, 2017
@vohmar vohmar mentioned this issue Jun 12, 2017
Open
@vohmar
Copy link
Contributor

vohmar commented Jun 12, 2017

  1. The problem is that admin cannot trust the data displayed by the admin interface - it shows effective price list items in expired list making the filters unreliable.
  2. new ticket created (Save filter params to enable going back to filtered lists after save #542)

@vohmar
Copy link
Contributor

vohmar commented Jun 12, 2017

  1. will be solved in Time is not supported as validity in price form #538 / Add extended price lookup policy #313

@vohmar
Copy link
Contributor

vohmar commented Jun 12, 2017 •
edited
Loading

  • Please add name to all filter in /admin/prices - ie 'all'

@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 12, 2017
artur-intech pushed a commit that referenced this issue Jun 12, 2017
Improve price search form UI
2886cb5 
#522
@artur-intech
Copy link
Contributor Author

Staging is updated.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Jun 12, 2017
artur-intech pushed a commit that referenced this issue Jun 13, 2017
Improve price search form UI
19eb8f9 
#522
@vohmar
Copy link
Contributor

vohmar commented Jun 13, 2017

merged to master

@vohmar
Copy link
Contributor

vohmar commented Jun 16, 2017

in production

@vohmar vohmar closed this as completed Jun 16, 2017
@artur-intech artur-intech mentioned this issue Aug 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vohmar @artur-intech