Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rubocop inspections #579

Closed
artur-intech opened this issue Aug 20, 2017 · 0 comments
Closed

Improve Rubocop inspections #579

artur-intech opened this issue Aug 20, 2017 · 0 comments
Assignees
@vohmar

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Aug 20, 2017 •
edited
Loading

Current problems:

  • Violates established coding conventions
  • Shows overwhelming amount of errors (builds are red most of the time because of legacy code)
@artur-intech artur-intech self-assigned this Aug 20, 2017
@artur-intech artur-intech changed the title Rubocop config violates established coding conventions Improve Rubocop inspections Aug 23, 2017
artur-intech pushed a commit that referenced this issue Aug 23, 2017
Update rubocop gem
4ac7fb1 
#579
artur-intech pushed a commit that referenced this issue Aug 23, 2017
Reformat Gemfile
e29768f 
#579
artur-intech pushed a commit that referenced this issue Aug 23, 2017
Improve Rubocop inspections
a7ea80a 
- Use default config
- Make offences snapshot

The latter suppresses current offences while reports new ones

#579
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Aug 23, 2017
@artur-intech artur-intech mentioned this issue Aug 24, 2017
Closed
@vohmar vohmar closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vohmar @artur-intech