Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: present deleteCandidate status in red #792

Closed
vohmar opened this issue Mar 26, 2018 · 7 comments
Closed

Admin: present deleteCandidate status in red #792

vohmar opened this issue Mar 26, 2018 · 7 comments
Assignees

Comments

@vohmar
Copy link
Contributor

vohmar commented Mar 26, 2018

/admin/domains/id

Display deleteCandidate status in different color ie in red in admin (and other web interfaces if possible (registrar, registrant)) to stress this status being present and make it easily noticable

@artur-intech
Copy link
Contributor

artur-intech commented Apr 2, 2018

Perhaps you would also like to have some flag in domain list? Say, like this: http://prntscr.com/izk1fj
Also, how about a label right after the name of a domain, instead of red colour somewhere in the bottom of the page? http://prntscr.com/izk3hl

@artur-intech
Copy link
Contributor

#784

artur-intech pushed a commit that referenced this issue Apr 2, 2018
@vohmar
Copy link
Contributor Author

vohmar commented Apr 2, 2018

There is no need for separation on general domain list. Label idea got postive feedback - the goal is to make it easily noticable that the domain admin is working with is already waiting for deletion.

artur-intech pushed a commit that referenced this issue Apr 2, 2018
artur-intech pushed a commit that referenced this issue Apr 2, 2018
artur-intech pushed a commit that referenced this issue Apr 2, 2018
artur-intech pushed a commit that referenced this issue Apr 2, 2018
artur-intech pushed a commit that referenced this issue Apr 2, 2018
@artur-intech
Copy link
Contributor

artur-intech commented Apr 2, 2018

Perhaps you would also like to be able to "keep" it once a domain has been discarded (has deleteCandidate status)?

Say some link saying "This domain has been discarded and awaits deletion. Keep it" (where the latter is a link, which keeps a domain).

@artur-intech artur-intech assigned vohmar and unassigned artur-intech and vohmar Apr 3, 2018
artur-intech pushed a commit that referenced this issue Apr 3, 2018
@vohmar
Copy link
Contributor Author

vohmar commented Apr 3, 2018

we have status based processes - we set and remove statuses. No need to duplicate it by extra links . Furthermore we do not discard domains.

@artur-intech
Copy link
Contributor

artur-intech commented Apr 3, 2018

we set and remove statuses

Well, at least from OOP point of view, this approach will not lead to understandable and maintainable software. I am open to your suggestions regarding good naming for this operation.

@vohmar
Copy link
Contributor Author

vohmar commented Apr 23, 2018

in production

@vohmar vohmar closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants