Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor domain delete mailer #1156

Merged
merged 6 commits into from
Apr 11, 2019
Merged

Refactor domain delete mailer #1156

merged 6 commits into from
Apr 11, 2019

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Apr 9, 2019

  • Add mailer preview
  • Improve readability
  • DRY templates
  • Add tests

Verify confirmation email sent upon domain deletion (https://github.com/internetee/registry/blob/1d17c935acb64e183b544424f896dd630ab994f9/app/views/mailers/domain_delete_mailer/confirmation.text.erb).

@artur-intech artur-intech force-pushed the refactor-domain-delete-mailer branch from f19d5d7 to 1d17c93 Compare April 9, 2019 11:52
@artur-intech artur-intech changed the title Improve readability Refactor domain delete mailer Apr 9, 2019
@artur-intech artur-intech assigned vohmar and unassigned vohmar Apr 9, 2019
@vohmar vohmar merged commit 7e0fd30 into master Apr 11, 2019
@vohmar vohmar deleted the refactor-domain-delete-mailer branch April 30, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants