Improve setup and seed #1352
Improve setup and seed #1352
Conversation
Add database constraints
[ci skip]
There was a problem hiding this comment.
Can you describe the point of having bin/setup.deps? Is it so that setup will be used for development instances, and bin/setup.deps for production-like ones?
.deps is quite unusual. Can we find some more descriptive name, like setup_prod? (given I was correct. But then I wonder if we really need two versions. Would be good to understand the motive of having this script).
bin/setup.deps
Outdated
| system(*args) || abort("\n== Command #{args} failed ==") | ||
| end | ||
|
|
||
| def get_uid() |
There was a problem hiding this comment.
effective_user_id might explain the intention better. () can be skipped.
bin/setup.deps
Outdated
|
|
||
| def get_uid() | ||
| uid = `id -u` | ||
| uid.delete!("\n") |
There was a problem hiding this comment.
Perhaps https://ruby-doc.org/core-2.4.5/String.html#method-i-strip is a better fit?
bin/setup.deps
Outdated
|
|
||
| puts "== Installing rbenv ruby manager to #{ENV['HOME']} ==" | ||
| unless Dir.exist?("#{ENV['HOME']}/.rbenv/") | ||
| system! 'git clone https://github.com/sstephenson/rbenv.git $HOME/.rbenv' |
There was a problem hiding this comment.
Perhaps https://github.com/rbenv/rbenv.git looks more official? This way you don't need to figure out who is that "sstephenson" every time you see this.
bin/setup.deps
Outdated
|
|
||
| # Include RBENV in path | ||
| ENV['PATH'] = ENV['HOME'] + "/.rbenv/bin:" + ENV['HOME'] + "/.rbenv/plugins/ruby-build/bin:" + ENV['PATH'] | ||
| NEEDED_RUBY = `cat .ruby-version`.freeze |
There was a problem hiding this comment.
NEEDED_RUBY_VERSION is more intention revealing.
bin/setup.deps
Outdated
| ENV['PATH'] = ENV['HOME'] + "/.rbenv/bin:" + ENV['HOME'] + "/.rbenv/plugins/ruby-build/bin:" + ENV['PATH'] | ||
| NEEDED_RUBY = `cat .ruby-version`.freeze | ||
|
|
||
| if '!bundle check' == false |
There was a problem hiding this comment.
'!bundle check' == false is always false. Did you mean backtick instead of a single quote?
db/seeds.rb
Outdated
| roles: ['admin'] | ||
| ) | ||
| # Required for creating registrar | ||
| Setting.where('var': 'registry_vat_prc').first_or_create( |
There was a problem hiding this comment.
There was a problem hiding this comment.
I could not figure out how to load defaults variables from app.yml it isn't done automatically
db/seeds.rb
Outdated
| value: '0.2' | ||
| ) | ||
| # First registrar | ||
| Registrar.where('name': 'Registrar First').first_or_create!( |
There was a problem hiding this comment.
Why do you need to create a registrar? Given you create an AdminUser on line 5, he can login by itself and create registrars by himself. Unlikely anybody will benefit from such registrar.
There was a problem hiding this comment.
The idea is to have demo data set there to ease the testing of features in development
There was a problem hiding this comment.
rake db:fixtures:load should be used for this.
There was a problem hiding this comment.
Dummy data is already available in test/fixtures.
| code: 'REG1' | ||
| ) | ||
|
|
||
| # registrar.accounts.create!(account_type: Account::CASH, currency: 'EUR') |
There was a problem hiding this comment.
Remove it entirely if not needed. Git history has it anyway.
There was a problem hiding this comment.
They will be enabled in future commits
db/seeds.rb
Outdated
| @@ -1,2 +1,59 @@ | |||
| # This file should contain all the record creation needed to seed the database with its default values. | |||
| # The data can then be loaded with the rake db:seed (or created alongside the db with db:setup). | |||
| # The data can then be loaded with the rake db:seed (or created alongside the db with db:setup). | |||
| ActiveRecord::Base.transaction do | |||
| AdminUser.where('username': 'admin').first_or_create!( | |||
There was a problem hiding this comment.
It should be username: 'admin' (:username is a symbol).
|
@teadur Wouldn't it be better to update Rubocop in a separate PR? It's kinda confusing why there are so many CodeClimate issues. At the very minimum it should be separate commit. Currently there are way too many unrelated changes in a single commit (e70fa4c). If we need to do something with it (revert, cherry-pick, etc), we're in trouble. |
Fix mailer preview
[ci skip]
Reorganize tests
Remove unused rake task
Update `ransack` gem
Update CHANGELOG.md
Update CHANGELOG.md
Downgrade `minitest` gem
[ci skip]
Remove dead code
Add database constraints
[ci skip]
Update `kaminari` gem
[ci skip]
Update CHANGELOG.md
…e/registry into improve-setup-and-seed
This reverts commit fdd53ee
|
@artur-beljajev rebased on master and will be squash merged to master. |
Retry of #1296
First part of fixing #960, install gem deps and setup db in bin/setup.
Install gem build deps in bin/setup.deps.
Provide db:seed with initial data.
New codeclimate issues are result of rubocop-i version increase not my code changes, because of that i think it makes more sense to merge the PR and work on the new issues gradually not in this PR.