Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused gems #1358

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Remove unused gems #1358

merged 2 commits into from
Sep 18, 2020

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Oct 11, 2019 •
edited
Loading

We don't use them and they seem to be effectively abandoned.

Also, removing autodoc gem allows us to fully get rid of rspec dependency.

@artur-intech
Copy link
Contributor Author

artur-intech commented Dec 6, 2019 •
edited
Loading

@vohmar Is there anything that prevents this from being merged? It is extremely important to remove gems that do not add any value.

@vohmar
Copy link
Contributor

vohmar commented Jan 3, 2020

these gems are used for automatically updating / generating documentation

@vohmar vohmar removed their assignment Jan 3, 2020
@teadur
Copy link
Contributor

teadur commented Aug 18, 2020

Seems to be related to #247

@yulgolem yulgolem marked this pull request as draft September 18, 2020 09:12
@yulgolem yulgolem self-assigned this Sep 18, 2020
@yulgolem
Copy link
Contributor

sdoc gem will be substituted for yard gem.

@yulgolem yulgolem marked this pull request as ready for review September 18, 2020 10:16
@yulgolem yulgolem assigned vohmar and unassigned yulgolem Sep 18, 2020
@vohmar vohmar merged commit afa15fe into master Sep 18, 2020
@yulgolem yulgolem deleted the remove-unused-gems branch October 1, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artur-intech @vohmar @teadur @yulgolem