Add new ForceDelete procedures #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
9 times, most recently
from
dd4ef5b to
4ae7cc4
Compare
yulgolem
changed the title
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
6 times, most recently
from
9f5c9e2 to
4d88989
Compare
karlerikounapuu
approved these changes
Dec 9, 2019
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
6 times, most recently
from
23a2748 to
3c63f92
Compare
|
Need to be run daily DomainCron.start_client_hold |
karlerikounapuu
approved these changes
Dec 17, 2019
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
from
2c4035c to
f20518b
Compare
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
8 times, most recently
from
c714dc1 to
91d35a1
Compare
Add new test file new_force_delete_test.rb to check if new ForceDeleteProcedures are correct. ATM it's just a scaffold of some sort, all tests are red, magic numbers and so - just a proof of concept. See #1428
This reverts commit 392b145.
Add removing forceDelete on registrant change. Restore email template choosing on safe force delete via admin dashboard. See #1428 (comment)
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
3 times, most recently
from
ae2e2ac to
79869ac
Compare
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
2 times, most recently
from
272996b to
847321c
Compare
yulgolem
force-pushed
the
1428-new-force-delete-procedures
branch
from
847321c to
e758124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new test file new_force_delete_test.rb to check if new ForceDeleteProcedures are correct.
See #1428