Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dev config to sample file #1599

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Move dev config to sample file #1599

merged 3 commits into from
Jun 4, 2020

Conversation

maciej-szlosarczyk
Copy link
Contributor

There should be no impact on production environment.

NB! This will remove existing development.rb file @karlerikounapuu @yulgolem. You can restore it by running:

$ cp config/environments/development.rb.sample config/environments/development.rb

@@ -5,33 +5,64 @@ Rails.application.configure do
# every request. This slows down response time but is perfect for development
# since you don't have to restart the web server when you make code changes.
config.cache_classes = false
config.autoload = :classic
Copy link
Member

@karlerikounapuu karlerikounapuu Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can actually be removed- residue from testing when I was wondering why I couldn't turn off Zeitwerk. Real key was config.autoloader = :classic and it's present in application.rb anyway as of now :)

@maciej-szlosarczyk
Copy link
Contributor Author

I have also removed the assets from precompile path as it started segfaulting on travis.

@vohmar vohmar merged commit 79bb620 into master Jun 4, 2020
@vohmar vohmar deleted the remove-development-env-file branch June 15, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants