Gather data about bounced emails via API #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
2 times, most recently
from
af6fcbe to
bc1db7b
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
bc1db7b to
834b2c9
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
d18fc87 to
f79785c
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
f79785c to
03182f9
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
6a4c99e to
603e240
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
2 times, most recently
from
cc0bcf8 to
1e37190
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
1e37190 to
101d5d4
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
8aa106a to
a54dda5
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
a54dda5 to
818869d
Compare
yulgolem
reviewed
Sep 21, 2020
yulgolem
approved these changes
Sep 21, 2020
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
3 times, most recently
from
4025231 to
7648af2
Compare
karlerikounapuu
force-pushed
the
log-bounced-emails
branch
from
7648af2 to
574846c
Compare
|
Amazon access info: https://intra.internet.ee/projects/infra/wiki/Amazon |
yulgolem
reviewed
Oct 28, 2020
| @bounced_mail.diagnostic = 'smtp; 550 5.1.1 user unknown' | ||
| end | ||
|
|
||
| def test_email_is_required |
There was a problem hiding this comment.
There is no need to test if field is required - we are set it presence to be validated and validation is already tested in rails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rest-whois#115
Run database migrations
Add
api_shared_keykey toconfig/application.ymlwith random value. This is shared key value between registry and rest-whois to authorize POST request.It's expected that HTTP's
Authorizationheader is arriving to rails and not thrown away.