Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github actions to run unit tests #1746

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Use github actions to run unit tests #1746

merged 2 commits into from
Dec 8, 2020

Conversation

teadur
Copy link
Contributor

@teadur teadur commented Nov 17, 2020

example workflow

@teadur teadur changed the title Create ruby.yml WIP: Create ruby.yml Nov 17, 2020
@teadur
Copy link
Contributor Author

teadur commented Nov 23, 2020

Dropped testing on ubuntu 20 ( problems with wkhtmltopdf-bin ) and ruby 3.0 (tests fail with core dump)
Some work to support ruby 3.0, dropped mina/listener gems to speed up deploy.
Please Squash and merge after review.

@teadur teadur changed the title WIP: Create ruby.yml Use github actions to run unit tests Nov 23, 2020
@yulgolem
Copy link
Contributor

yulgolem commented Nov 24, 2020 •
edited
Loading

Got a question - is it possible to point CodeClimate test coverage checks to one of GA test envs?

BTW checked speed of GA deploy - it's about 3 to 5 minutes compared to current 40+ minutes in Travis. Nice result, thank you.

@teadur
Copy link
Contributor Author

teadur commented Dec 2, 2020 •
edited
Loading

Got a question - is it possible to point CodeClimate test coverage checks to one of GA test envs?

BTW checked speed of GA deploy - it's about 3 to 5 minutes compared to current 40+ minutes in Travis. Nice result, thank you.

GA now runs CodeClimate checks, not sure why the total-coverage falls -13.5% thou :|
https://codeclimate.com/github/internetee/registry/compare/331ade988c2e891d8addc634e105bf68318defc3...9bcba24b50766726edb74ebb689792f4572562f1#ratings

@karlerikounapuu karlerikounapuu self-requested a review December 7, 2020 08:46
@teadur @yulgolem
Create ruby.yml
36ff1fc 
example workflow

Update ruby.yml

limit builds

Update ruby.yml

postgres service

Update ruby.yml

pg_port

copy config files

Update ruby.yml

Update ruby.yml

Update database_travis.yml

Update ruby.yml

Update ruby.yml

bump wkhtmltopdf-binary

Unlock gem 'wkhtmltopdf-binary'

Update ruby.yml

Update ruby.yml

Update ruby.yml

remove Lockfile

restore Gemfile

test only ubuntu-18.04

bundle env

remove deploy deps

remove mina dep

use rexml from bundle rather then std-lib to support ruby 3.0

install rexml

drop ruby 3.0, cleanup workflow

fix codeclimate sorting issue

Codeclimate reporting

stop using deprecated set-env

use simplecov formater

simplecov in after-build

fix yaml syntax

run in debug mode

Set correct env var to run coverage

cleanup, provide CC_TEST_REPORTER_ID secret

combine multiple results

more variables

pull/commit different envs

Change test command to get more coverage
@yulgolem
Copy link
Contributor

yulgolem commented Dec 7, 2020

Changed test command to up the coverage, rebased from master & squashed, removed TravisCI support.
PR is ready to merge.

@teadur
Copy link
Contributor Author

teadur commented Dec 8, 2020

Changed test command to up the coverage, rebased from master & squashed, removed TravisCI support.
PR is ready to merge.

Nice, thank you :)

@vohmar vohmar merged commit 42b9adb into master Dec 8, 2020
@vohmar vohmar deleted the gh-actions-test branch January 28, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulgolem yulgolem yulgolem approved these changes

@karlerikounapuu karlerikounapuu karlerikounapuu approved these changes

Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teadur @yulgolem @karlerikounapuu @vohmar