Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added init which returns definitly count of domains #1969

Merged
merged 4 commits into from
May 19, 2021
Merged

added init which returns definitly count of domains #1969

merged 4 commits into from
May 19, 2021

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon mentioned this pull request May 7, 2021
Merged
@OlegPhenomenon OlegPhenomenon force-pushed the show-all-domains-by-default-to-users-with-less-than-3000-associated-domains branch 2 times, most recently from a915dba to c010f1d Compare May 10, 2021 09:13
@OlegPhenomenon OlegPhenomenon force-pushed the show-all-domains-by-default-to-users-with-less-than-3000-associated-domains branch from c010f1d to f64898d Compare May 10, 2021 09:32
@OlegPhenomenon
Copy link
Contributor Author

Related to -> internetee/registrant_center#54

@OlegPhenomenon OlegPhenomenon requested a review from yulgolem May 10, 2021 09:37
yulgolem
yulgolem suggested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@yulgolem yulgolem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Rails way "initializer" is a config file for some external lib/gem/service put into /config/initializers folder, so I'd ask to consider renaming the PR and entities.

BTW why shouldn't we call method just something like 'init_count_*'?

app/controllers/api/v1/registrant/domains_controller.rb Outdated Show resolved Hide resolved
app/controllers/api/v1/registrant/domains_controller.rb Outdated Show resolved Hide resolved
@OlegPhenomenon OlegPhenomenon force-pushed the show-all-domains-by-default-to-users-with-less-than-3000-associated-domains branch from 2af13de to c46b22d Compare May 10, 2021 10:10
@OlegPhenomenon OlegPhenomenon requested a review from yulgolem May 10, 2021 11:22
@OlegPhenomenon OlegPhenomenon changed the title added initializer which returns definitly count of domains added init which returns definitly count of domains May 10, 2021
@vohmar vohmar merged commit 670d42e into master May 19, 2021
@vohmar vohmar deleted the show-all-domains-by-default-to-users-with-less-than-3000-associated-domains branch June 8, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulgolem yulgolem yulgolem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegPhenomenon @yulgolem @vohmar