Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added validation before update #2206

Merged
merged 33 commits into from
Feb 9, 2022
Merged

Conversation

OlegPhenomenon
Copy link
Contributor

Close #1897

@viezly
Copy link

viezly bot commented Nov 4, 2021

This pull request is split into 5 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app/jobs
  • app/mailers
  • app/models
  • app/services
  • app/views/mailers/contact_inform_mailer
  • config/locales
  • db
  • test/integration/api/registrant
  • test/jobs
  • test/services

@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch 2 times, most recently from 7144aa7 to ec6fb01 Compare November 4, 2021 14:23
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch from b7e597b to eab1cd8 Compare November 16, 2021 11:24
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch 2 times, most recently from dae8022 to 6a3592f Compare November 25, 2021 12:52
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch 3 times, most recently from 209dd2f to 938108c Compare December 31, 2021 09:26
@OlegPhenomenon OlegPhenomenon marked this pull request as ready for review December 31, 2021 09:29
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch 5 times, most recently from 04fb2dd to 20a86ed Compare January 12, 2022 12:31
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch from b7c1c76 to 12e6333 Compare January 13, 2022 08:33
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch from 12e6333 to 17f104f Compare January 27, 2022 07:32
@vohmar
Copy link
Contributor

vohmar commented Feb 9, 2022

Please add an option on running the validation job that would hold off notifying regsitrants and registrars about found issues so we can do the the initial run without alerting anyone and see what kind of issues we will find in production

Using these results we need to improve the notification polls and emails that we are sending out

@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch 3 times, most recently from 517c5f0 to fb8fe15 Compare February 9, 2022 09:52
@OlegPhenomenon OlegPhenomenon force-pushed the 1897-add-sub-zone-dnskey-check branch from fb8fe15 to d99330a Compare February 9, 2022 13:16
@vohmar vohmar merged commit b4166cd into master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sub-zone dnskey check on adding new dnskey to a domain
3 participants