Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added endpoints to demo registry for accr results #2237

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon commented Dec 10, 2021

Related to internetee/accreditation_center#131

In these files add env conditions:

repp/v1/registrar/accreditation_results_controller.rb
repp/v1/registrar/accreditation_info_controller.rb
api/v1/accreditation_center/base_controller.rb

Rails.env.development? || Rails.env.staging? || Rails.env.test?
When will added new env demo, then this env conditions need to change to Rails.env.demo?

Added a new condition for displaying an endpoint in an isolated environment. To do this, you need to add the key in application.yml allow_accr_endspoints: 'true' for the test registry environment. Then endpoints for working with registry production will be available. For other environments, for example, for staging and production, this key can be omitted.

in application.yml need to add these keys:

registry_demo_registrar_port: '3000'
registry_demo_registrar_results_url: 'http://registry.test/api/v1/accreditation_center/results'
registry_demo_registrar_api_user_url: 'http://registry.test/api/v1/accreditation_center/show_api_user'
registry_demo_accredited_users_url: 'http://registry.test/api/v1/accreditation_center/list_accreditated_api_users'

These links below are endpoints
instead http://registry.test/ should base url of demo env registry

Job, which check all user api in demo env database called by SyncAccreditedUsersJob.perform_now

@viezly
Copy link

viezly bot commented Dec 10, 2021

This pull request is split into 6 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app
  • app/controllers
  • app/interactions/actions
  • app/models
  • app/views/admin
  • config
  • db
  • test

@OlegPhenomenon OlegPhenomenon force-pushed the added-enpoint-to-test-registry-for-acrr-results branch 4 times, most recently from 27c4d31 to 65c58a0 Compare December 13, 2021 09:50
@OlegPhenomenon OlegPhenomenon self-assigned this Dec 13, 2021
@OlegPhenomenon OlegPhenomenon force-pushed the added-enpoint-to-test-registry-for-acrr-results branch 3 times, most recently from 987d701 to 9af2242 Compare March 1, 2022 10:23
@OlegPhenomenon OlegPhenomenon force-pushed the added-enpoint-to-test-registry-for-acrr-results branch from 9af2242 to dadf74d Compare March 9, 2022 13:26
@OlegPhenomenon OlegPhenomenon marked this pull request as ready for review March 25, 2022 09:38
@OlegPhenomenon OlegPhenomenon force-pushed the added-enpoint-to-test-registry-for-acrr-results branch from dadf74d to 5c3ee57 Compare April 13, 2022 11:36
@OlegPhenomenon OlegPhenomenon force-pushed the added-enpoint-to-test-registry-for-acrr-results branch from 5c3ee57 to 44296ab Compare September 29, 2022 07:17
@vohmar vohmar merged commit 397cb8b into master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants