Prevent deprecated validation events #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
thiagoyoussef
force-pushed
the
2374-deprecated-validation-events
branch
from
98f7fd2 to
8e2984d
Compare
thiagoyoussef
force-pushed
the
2374-deprecated-validation-events
branch
2 times, most recently
from
4fd90b1 to
7a2256a
Compare
OlegPhenomenon
requested changes
May 16, 2022
| validation_eventable.validation_events.first.destroy | ||
| end | ||
| end | ||
| destroy_old_validations(events, 3) if @check_level == 'mx' && !result.success |
There was a problem hiding this comment.
What happen if we decide to change validation events limit? For example from 3 to 4. For this it will need to search code in whole project what responsibility for it. Also, if I didn't know nothing about validation, number 3 will be for me incomprehensible attribute. Please check validation_event model, there is should be constant where is assigned default validation limit and please change number 3 to this constant
(and yes, I know that I am too used numbers instead constants and this is also my fall :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2374