Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set session timeout to 5 years in development and staging environments #588

Merged
merged 4 commits into from
Sep 27, 2017
Merged

Set session timeout to 5 years in development and staging environments #588

merged 4 commits into from
Sep 27, 2017

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Sep 16, 2017 •
edited
Loading

  • Needed to avoid signing in every 8 hours
  • Nothing to test

@teadur
Copy link
Contributor

teadur commented Sep 25, 2017

Maybe we should have lower value for production then 8 hours. @ratM1n
I think something smaller then 5 years for devel/staging would be "nicer".

@artur-intech
Copy link
Contributor Author

artur-intech commented Sep 26, 2017 •
edited
Loading

Georg

hour for prod, day for staging and 0 for dev

@artur-intech
Copy link
Contributor Author

@ratM1n @teadur This is now configurable option
030eaa3#diff-318c31f2f8c28eecdbe0119432a98af0R131

@artur-intech
Copy link
Contributor Author

artur-intech commented Sep 26, 2017 •
edited
Loading

Please make sure all envs are updated with the corresponding values.

@vohmar vohmar requested a review from teadur September 27, 2017 13:20
@vohmar
Copy link
Contributor

vohmar commented Sep 27, 2017

this is now deployed on staging @teadur please test this configurable feature.

teadur
teadur approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@teadur teadur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

@vohmar vohmar merged commit 31fdf8a into master Sep 27, 2017
@artur-intech artur-intech deleted the disable-session-timeout-for-development-and-staging branch October 4, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teadur teadur teadur approved these changes

Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artur-intech @teadur @vohmar