Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry 700 #710

Merged
merged 42 commits into from
Feb 20, 2018
Merged

Registry 700 #710

merged 42 commits into from
Feb 20, 2018

Conversation

artur-intech
Copy link
Contributor

No description provided.

Artur Beljajev added 30 commits February 6, 2018 23:36
Do not allow NULL in epp_sessions.session_id
34f7820 
#700
Convert spec to test
cdb0187 
#700
Do not use factory
a757a92 
#700
Remove factory
4163ee9 
#700
Disallow blank EppSession#session_id
1c560b1 
#700
Remove unneeded if statement
d5b9606 
epp_session.session_id is always present

#700
Remove test logic
82c74a4 
#700
Add epp_sessions.user_id
ba341ee 
#700
Decompose EppSession#data
940613a 
#700
Revert "Remove factory"
cf5ea5a 
This reverts commit 4163ee9.
Fix invalid factory
ad1f5e6 
#700
Fix EPP login in specs
278ae07 
#700
Remove rspec helper
2dcf0f5 
#700
Rename migration
c5f8c7e 
#700
Migrate epp_sessions.data to user_id
38f967a 
#700
Improve CodeClimate config
7fa75f3
Quote values
114361f 
#700
Merge branch 'master' into registry-700
f06eb11
Create new EPP session on login explicitly
b11306e 
#700
Remove extra attribute
fa6edab 
Registrar can be queried from user

#700
Replace index with constraint
5a101dd 
#700
Add EPP session tests
e2c90cd 
#700
Improve readability
40c1238 
#700
Ensure unique EPP session id
4ec4e50 
#700
Remove invalid association
3c274ba 
Completes fa6edab

#700
Add NOT NULL constraint
1f66f13 
#700
Add database constraint test
fc6a2df 
Having session_id constraints at the database level is crucial

#700
Remove unused view
6f1f121 
#700
Document test
2ce4fa9 
#700
Require authentication on EPP logout
ec43586 
#700
@artur-intech artur-intech requested a review from teadur February 14, 2018 02:11
@teadur teadur mentioned this pull request Feb 19, 2018
Closed
@teadur teadur added the blocked label Feb 19, 2018
@teadur
Copy link
Contributor

teadur commented Feb 19, 2018

cannot review before #711 is fixed as @artur-beljajev mentions in #700

@vohmar
Copy link
Contributor

vohmar commented Feb 20, 2018

reference to #711 means that session limit will be fixed after that bug is resolved (#729)

@vohmar vohmar merged commit 91c60c2 into master Feb 20, 2018
@vohmar vohmar deleted the registry-700 branch February 23, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teadur teadur Awaiting requested review from teadur

Assignees

@vohmar vohmar

Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artur-intech @teadur @vohmar