Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby #139

Closed
wants to merge 31 commits into from
Closed

Upgrade Ruby #139

wants to merge 31 commits into from

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Nov 3, 2018

@maciej-szlosarczyk You probably want to tune Docker config as well? You mentioned some issue, if I remember correctly...

Closes #137

@artur-intech artur-intech assigned vohmar and unassigned vohmar Nov 3, 2018
@maciej-szlosarczyk
Copy link
Contributor

Not tune, but create a custom image as we no longer can use the approved Ruby image for variety of reasons:

  • There is no approved image of Ruby 2.5 with Jessie. There's a PR that dates back to February 2018, so it will not happen. Add ruby-2.5.0 based on debian jessie docker-library/ruby#189
  • live registry is stuck on Jessie because of EPP and how it is set up with Apache on the same machine.
  • Stretch drops postgres-client 9.4, we are stuck with it because upgrading to higher version changes how pg_dump and pg_restore work. We should sooner rather than later move to 9.6 if not for safety then to get UPSERT and parallel queries that came respectively in 9.5 and 9.6.

Anyway, there is extra work involved with this change now and going forward because now we/I have to maintain the docker images even for point releases.

@vohmar
Copy link
Contributor

vohmar commented Nov 30, 2018

merge conflicts with master

@artur-intech
Copy link
Contributor Author

artur-intech commented Nov 30, 2018

Everything I wanted to merge to master until commit 7fd16c1 (see above) is already in master. No idea why there are some additional commits from Georg are here...

We could just discard this PR, I guess.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Nov 30, 2018
@teadur
Copy link
Contributor

teadur commented Nov 30, 2018

@artur-beljajev why not close it then ? the pull request is opened by you ?
As of i dont see the point in bouncing the pull request around i shall close it myself to save everyones time :)

@teadur teadur closed this Nov 30, 2018
@vohmar vohmar deleted the upgrade-ruby branch November 30, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants